On Tue, 2011-03-22 at 09:40 +0200, Eliad Peller wrote: > On Mon, Mar 21, 2011 at 11:19 PM, Luciano Coelho <coelho@xxxxxx> wrote: > > We were using an array of booleans to mark the channels we had already scanned. This was causing a sparse error, because bool is not a type with defined size. To fix this, use bitmasks instead, which is much cleaner anyway. > > > > Thanks Johannes Berg for the idea. > > > > Signed-off-by: Luciano Coelho <coelho@xxxxxx> > > --- > [...] > > + /* make sure all our channels fit in the scanned_ch bitmask */ > > + BUG_ON(ARRAY_SIZE(wl1271_channels) + ARRAY_SIZE(wl1271_channels_5ghz) > > > + WL1271_MAX_CHANNELS); > > maybe use BUILD_BUG_ON here? Yeah, I had actually done that at first. But then the compilation error was so cryptic that I decided to add a BUG_ON instead. But now I realize that the BUG_ON is just as cryptic, so I can change it back to BUILD_BUG_ON. In either case, the developer will know soon enough that there is a bug. :) I'll change it to BUILD_BUG_ON before applying. Thanks! -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
