Hi Johannes, > -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Friday, March 11, 2011 12:21 PM > To: Bing Zhao > Cc: linux-wireless@xxxxxxxxxxxxxxx; John W. Linville; Joe Perches; Nishant Sarmukadam; Amitkumar > Karwar; Kiran Divekar; Yogesh Powar; Marc Yang; Ramesh Radhakrishnan; Frank Huang > Subject: Re: [PATCH v2] wireless: mwifiex: initial commit for Marvell mwifiex driver > > Just random comments, maybe I'll find time for a more in-depth review. Thanks for the comments. > > > > + * CFG802.11 operation handler to set the default network key. > > + */ > > +static int > > +mwifiex_cfg80211_set_default_key(struct wiphy *wiphy, struct net_device *netdev, > > + u8 key_index, bool unicast, > > + bool multicast) > > +{ > > + return 0; > > +} > > This doesn't seem right. It might work in some/most test cases, but it > still seems like an API workaround. It will be fixed. > > > Also, you have a ton of debugfs file API. Are you sure that's a good > thing? Is it all really for debugging only? Also things like > "passphrase" there make me very suspicious about what the driver is > doing there. There doesn't seem to be any reason at all to provide an > interface for a passphrase? I will check on the debugfs APIs. > > But really I'm too tired right now to look at this, maybe Monday. Thanks very much for your time. I really appreciate it. Regards, Bing > > johannes ÿô.nlj·Ÿ®‰†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf
