Just random comments, maybe I'll find time for a more in-depth review.
> + * CFG802.11 operation handler to set the default network key.
> + */
> +static int
> +mwifiex_cfg80211_set_default_key(struct wiphy *wiphy, struct net_device *netdev,
> + u8 key_index, bool unicast,
> + bool multicast)
> +{
> + return 0;
> +}
This doesn't seem right. It might work in some/most test cases, but it
still seems like an API workaround.
Also, you have a ton of debugfs file API. Are you sure that's a good
thing? Is it all really for debugging only? Also things like
"passphrase" there make me very suspicious about what the driver is
doing there. There doesn't seem to be any reason at all to provide an
interface for a passphrase?
But really I'm too tired right now to look at this, maybe Monday.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
