RE: [PATCH v2] mwifiex: remove PRINTM/HEXDUMP and associated

[Bing Zhao <bzhao@xxxxxxxxxxx>]

Hi Joe,

> Please use pr_fmt
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> to prefix "mwifiex: " rather than put it each
> format string.
 
For pr_debug, the original "fmt" is used to construct the _ddebug descriptor:

#define dynamic_pr_debug(fmt, ...) do {                                 \
        static struct _ddebug descriptor                                \
        __used                                                          \
        __attribute__((section("__verbose"), aligned(8))) =             \
        { KBUILD_MODNAME, __func__, __FILE__, fmt, __LINE__,            \
                _DPRINTK_FLAGS_DEFAULT };                               \
......

So the prefix won't appear in dynamic_debug/control as the "format" string.

Do you think we should use pr_fmt(fmt) to construct _ddebug descriptor?
        { KBUILD_MODNAME, __func__, __FILE__, pr_fmt(fmt), __LINE__,            \

Otherwise, I still have to add "mwifiex: " prefix for every pr_debug() call.

Thanks,

Bing

ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf