On Wed, 2011-03-02 at 14:31 -0800, Bing Zhao wrote: > use pr_debug family APIs instead. > MERROR/MFATAL/MMSG: pr_err, pr_warning, pr_notice Trivia: It looks to me as if all the MFATAL should map to KERN_ERR. Please use pr_fmt #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt to prefix "mwifiex: " rather than put it each format string. Please use pr_warn not pr_warning. I really don't think you need to add another prefix string like "err" and "info" and "cmd" to the various levels. The output content is enough to figure it out. Perhaps use use dev/netdev/wiphy_<level> where it makes sense? You've sometimes added __func__ and sometimes used or kept some shortened function name equivalent. It'd probably be better to consistently use __func__ where appropriate. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
