Search Linux Wireless

RE: [PATCH v2] mwifiex: remove PRINTM/HEXDUMP and associated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-03-03 at 11:24 -0800, Bing Zhao wrote:
> For example, I can do "format 'mwifiex cmd' +p" and
> "format 'mwifiex event' +p" to enable debugging for "cmd" and "event" only.

Cute.  That works.

Most similar current uses are a
integer bitmap equivalent.

echo bitmap_value > module_control_variable

if (module_control_variable & type)
	print...

I think that's cleaner and less error prone
myself but opinions certainly vary.

> > Perhaps use use dev/netdev/wiphy_<level> where it makes
> > sense?
> I thought that too. But these APIs require a parameter of "struct device *".
> Some of mwifiex_ functions do not have this parameter.

Sure, but the places that do have an available
struct device|net_device|wiphy should use the
equivalent appropriate call.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux