Search Linux Wireless

Re: [PATCH v3 5/5] iwlwifi: move remaining iwl-agn-rx.c code into iwl-rx.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stanislaw,

On Thu, 2011-03-03 at 01:19 -0800, Stanislaw Gruszka wrote:
> Hello
> 
> On Wed, Mar 02, 2011 at 12:00:09PM -0800, Guy, Wey-Yi wrote:
> > I got the following warning:
> > 
> > drivers/net/wireless/iwlwifi/iwl-rx.c:506:6: warning: symbol
> > 'iwl_rx_statistics' was not declared. Should it be static?
> > drivers/net/wireless/iwlwifi/iwl-rx.c:575:6: warning: symbol
> > 'iwl_reply_statistics' was not declared. Should it be static?
> > drivers/net/wireless/iwlwifi/iwl-rx.c:600:6: warning: symbol
> > 'iwl_rx_missed_beacon_notif' was not declared. Should it be static?
> 
> include "iwl-agh.h" should make warning go away, but perhaps
> would be better to move all rx_handlers to iwl-rx.c, make them
> statics and export only iwl_setup_rx_handlers ?
> 
I like the 2nd approach and make it "static", could you like to do it,
or I can make the changes.

Thanks
Wey


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux