On Mon, 2011-02-14 at 23:32 +0100, RafaÅ MiÅecki wrote: > Sure. It's not for submission, so you have to expect magic values. That patch doesn't look too bad. > Personally I don't like for example description at > http://bcm-v4.sipsolutions.net/802.11/PHY . It's really messed in "Put > PHY Into Reset". > Section "Put PHY Into Reset" is really "How to reset PHY" and it > duplicates code of takine PHY out of reset. Yeah, well. Maybe I repeat myself for the hundredth time: Do not duplicate the specifications exactly. Apply common sense before implementing the code. If we can do better on certain things, do it. > We also have a lot of magic in ssb_device_enable. We reset SB and PHY > at the same time. I guess it introduces some optimization but makes it > harder to understand, especially if you try to understand implemented > code and look as specs at the same time. Well, it's core specific flags. I don't see anything wrong here. I think the PHY reset might even require an actual core reset to work correctly. So you could never untie both. But that's exactly those magic things we're never going to find out unless we have hardware documentation. -- Greetings Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
