Search Linux Wireless

Re: [PATCH 1/5] iwlwifi: Simplify tx queue management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nathaniel,

On Sun, 2011-02-13 at 09:56 -0800, Nathaniel J. Smith wrote:
> Previously, the iwlwifi driver filled its transmit queue until it
> reached a high-water mark, and then stopped until it had fallen to a
> low-water mark. This basic logic makes sense for interrupt mitigation
> -- you might not want to wake up the CPU after every packet, but
> instead wait until a batch of packets has been sent -- except the
> iwlwifi driver doesn't actually do any interrupt mitigation; the CPU
> wakes up after every packet transmitted anyway. So we simplify the
> code to maintain only a single limit on total queue length, and
> whenever we drop below that limit we allow more packets in.
> 
> This patch should have no user-visible effect.
> 
> Signed-off-by: Nathaniel J. Smith <njs@xxxxxxxxx>
> ---
>  drivers/net/wireless/iwlwifi/iwl-3945.c     |    4 ++--
>  drivers/net/wireless/iwlwifi/iwl-4965.c     |    4 ++--
>  drivers/net/wireless/iwlwifi/iwl-agn-lib.c  |    4 ++--
>  drivers/net/wireless/iwlwifi/iwl-agn-tx.c   |    6 +++---
>  drivers/net/wireless/iwlwifi/iwl-dev.h      |    2 --
>  drivers/net/wireless/iwlwifi/iwl-tx.c       |   18 +++++++-----------
>  drivers/net/wireless/iwlwifi/iwl3945-base.c |    4 ++--
>  7 files changed, 18 insertions(+), 24 deletions(-)
> 
what device you test this with? I will like to see this changes with
newer device, especially with aggregation.

Thanks
Wey

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux