On Tue, 2011-02-08 at 22:28 -0800, Stanislaw Gruszka wrote: > On Tue, Feb 08, 2011 at 07:45:53AM -0800, wwguy wrote: > > > - priv->plcp_jiffies = stamp; > > > - > > > - if (msecs == 0) > > > - return true; > > > + BUG_ON(msecs == 0); > > > > why not just return? I understand it should not be "0", but really need > > BUG_ON? > > > > > > > > - stamp = jiffies; > > > - msecs = jiffies_to_msecs(stamp - priv->plcp_jiffies); > > > - priv->plcp_jiffies = stamp; > > > - > > > - if (msecs == 0) > > > - return true; > > > + BUG_ON(msecs == 0); > > Same above > > > > > > Similar question, we are very close to finish driver split, when is the > > best time for this patch? > > The same aswer :-) I will respin, when your patches will land in John tree. > Thank you Wey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html