Search Linux Wireless

Re: [PATCH 5/5] iwlwifi: avoid too frequent recover from statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 08, 2011 at 07:45:53AM -0800, wwguy wrote:
> > -	priv->plcp_jiffies = stamp;
> > -
> > -	if (msecs == 0)
> > -		return true;
> > +	BUG_ON(msecs == 0);
> 
> why not just return? I understand it should not be "0", but really need
> BUG_ON?
>  
> >  
> > -	stamp = jiffies;
> > -	msecs = jiffies_to_msecs(stamp - priv->plcp_jiffies);
> > -	priv->plcp_jiffies = stamp;
> > -
> > -	if (msecs == 0)
> > -		return true;
> > +	BUG_ON(msecs == 0);
> Same above
> 
> 
> Similar question, we are very close to finish driver split, when is the
> best time for this patch?

The same aswer :-) I will respin, when your patches will land in John tree.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux