Search Linux Wireless

Re: Missing skb_pad() return value checks in rt2x00 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ivo,

On Sun, Feb 6, 2011 at 5:17 PM, Ivo Van Doorn <ivdoorn@xxxxxxxxx> wrote:
> Between here and where you added the padding are a couple of function
> calls which use the skb->len field. So this patch would change the value what
> they expect. Have you checked the possible impact?

I don't think skb_pad() touches skb->len. It writes zeros into the tailroom:
/**
*      skb_pad                 -       zero pad the tail of an skb
*      @skb: buffer to pad
*      @pad: space to pad
*
*      Ensure that a buffer is followed by a padding area that is zero
*      filled. Used by network drivers which may DMA or transfer data
*      beyond the buffer end onto the wire.
*
*      May return error in out of memory cases. The skb is freed on error.
*/

Thanks,
Wolfgang
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux