On 01/26/2011 07:36 AM, Johannes Berg wrote:
On Fri, 2011-01-21 at 10:05 -0800, greearb@xxxxxxxxxxxxxxx wrote:
From: Ben Greear<greearb@xxxxxxxxxxxxxxx>
This should decrease un-necessary flushes, on/off channel work,
and channel changes in cases where the only scanned channel is
the current operating channel.
Signed-off-by: Ben Greear<greearb@xxxxxxxxxxxxxxx>
---
v2: Check channels instead of flag when determining if we should
do a channel change in scan_completed_finish.
Can you look at work.c -- where we call
ieee80211_offchannel_stop_beaconing etc.
In this patch, you're moving the call to
ieee80211_offchannel_stop_beaconing next to
ieee80211_offchannel_stop_station in scan.c.
Therefore, you can combine those two into one function.
However, I guess it'd also be nice to also address the TODO in work.c
and move the "don't do so much if not really off-channel" logic into
that function? You must run into that when trying to associate on one
vif and the others get stopped etc. unnecessarily to do that.
I think you are right about this, but due to the tricky nature
of this code, maybe save that for a second patch?
Thanks,
Ben
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
