On Tue, 2010-12-28 at 14:31 +0900, Bruno Randolf wrote: > > > - if (freq == ieee80211_channel_to_frequency(12) || > > > - freq == ieee80211_channel_to_frequency(13) || > > > - freq == ieee80211_channel_to_frequency(14)) > > > + if (freq == ieee80211_channel_to_frequency(12, IEEE80211_BAND_2GHZ) || > > > + freq == ieee80211_channel_to_frequency(13, IEEE80211_BAND_2GHZ) || > > > + freq == ieee80211_channel_to_frequency(14, IEEE80211_BAND_2GHZ)) > > > > > > return true; > > > > This seems strange ... why not just hardcode the values?? > > True, but this is not my code, I just did the change for the new function > parameter. It's in net/wireless/reg.c, so I'll CC: Luis. Right. It seems rather complicated though, especially with this change. > Any other comments on the code or purpose of this patch? Not really. I guess it seems fine. Do you know if there are ever any starting values used other than 4900 and 5000? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
