Search Linux Wireless

Re: [PATCH v2 1/2] ath9k_hw: Fix incorrect macversion and macrev checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 22, 2010 at 8:47 AM, Senthil Balasubramanian
<senthilkumar@xxxxxxxxxxx> wrote:
> There are few places where we are checking for macversion and revsions
> before RTC is powered ON. However we are reading the macversion and
> revisions only after RTC is powered ON and so both macversion and
> revisions are actully zero and this leads to incorrect srev checks.
>
> fix this by reading the macversion and revisisons even before we start
> using them. There is no reason why should we delay reading this info
> until RTC is powered on as this is just a register information.
>
> Cc: Stable Kernel <stable@xxxxxxxxxx>
> Signed-off-by: Senthil Balasubramanian <senthilkumar@xxxxxxxxxxx>
> ---
> v2 -- fixed reading revisions unnecessarily during every reset.

The description can be extended explaining what specific real life
issues this fixes and can help in the evaluation for stable, consider
helping to the extend even Andi Kleen can read this and easily decide
to either suck this into 2.6.35 longterm or not. To help with this it
will help to know what chipsets are affected and so on. I suspect it
can say something like:

"This fixes programming the hardware incorrectly for x and y chipsets
where the wrong chipset was being picked up. Without this those
chipsets would be programmed incorrectly and would not be functional"

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux