On Wed, Dec 22, 2010 at 9:03 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2010-12-20 at 12:02 -0500, Luis R. Rodriguez wrote: > >> + Â Â u8 dfs_region; > > u8, when the real value is a u16? Ah see the field is actually a country flag, but here we just extract the DFS region. >> + Â Â last_request->dfs_region = (cfg80211_regdomain->flags & >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â NL80211_CFLAG_ALL_DFS_FLAGS); > > Also -- "regions", not "region" since it's still a bitmask of values. If > you think it should be a single region, then you should have an enum > instead. You're right, for now we can enforce this to be just one region and if we later want to change it for whatever reason we can allow for one country to fall into multiple regions, if that makes sense. I hope to get a better idea from Michael today if this might make sense today. I'll reply to this thread once I do. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
