On Fri, Dec 17, 2010 at 7:14 AM, Mohammed Shafi Shajakhan
<mshajakhan@xxxxxxxxxxx> wrote:
> From: Mohammed Shafi Shajakhan <mshajakhan@xxxxxxxxxxx>
>
> ath9k channel table for 2Ghz does not seems to initialize the 'band'
> parameter.Though it does not seems to cause any visible issue it looks
> odd when we initialize the 'band' parameter for 5Ghz channel table while
> not so for 2Ghz.
>
> Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@xxxxxxxxxxx>
> ---
> Âdrivers/net/wireless/ath/ath9k/init.c | Â Â1 +
> Â1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index 1238795..b0e5e71 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -48,6 +48,7 @@ MODULE_PARM_DESC(pmqos, "User specified PM-QOS value");
> Â/* We use the hw_value as an index into our private channel structure */
>
> Â#define CHAN2G(_freq, _idx) Â{ \
> + Â Â Â .band = IEEE80211_BAND_2GHZ, \
> Â Â Â Â.center_freq = (_freq), \
> Â Â Â Â.hw_value = (_idx), \
> Â Â Â Â.max_power = 20, \
That's fine but its not needed at all as the band is already
kzalloc()'d so it gets zeroed out and the IEEE80211_BAND_2GHZ enum is
0, so its not required to be explicit and set it. But if it gives you
the warm fuzzies sure.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
