> > In 2.6.37-rc4, hostap_pci init gives a WARNING with backtrace telling > > that netif_stop_queue is called before register_netdev. Fix it by moving > > this call after register_netdev. Removes the warning and seems to work, > > but why is the call to netif_stop_queue needed at all after > > register_netdev? > > It should simply not touch the queue state at all at this point. > > Your change would add a race. At the moment the device is registered > it can be brought up, and then your code will eroneously modify > the queue state. OK, I can make a simpler patch for that but I would like to understand the original reasons for having netif_stop_queue there. Just a relict or still somehow important? Jouni? -- Meelis Roos (mroos@xxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
