Search Linux Wireless

Re: [PATCH] fix hostap registration order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Meelis Roos <mroos@xxxxxxxx>
Date: Fri, 10 Dec 2010 01:19:23 +0200 (EET)

> In 2.6.37-rc4, hostap_pci init gives a WARNING with backtrace telling 
> that netif_stop_queue is called before register_netdev. Fix it by moving 
> this call after register_netdev. Removes the warning and seems to work, 
> but why is the call to netif_stop_queue needed at all after 
> register_netdev?
> 
> Signed-off-by: Meelis Roos <mroos@xxxxxxxx>

It should simply not touch the queue state at all at this point.

Your change would add a race.  At the moment the device is registered
it can be brought up, and then your code will eroneously modify
the queue state.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux