On Tue December 7 2010 18:35:40 Johannes Berg wrote: > On Tue, 2010-12-07 at 11:17 +0900, Bruno Randolf wrote: > > On Mon December 6 2010 17:33:20 Johannes Berg wrote: > > > > > Finally, you should check for nl80211 that the given tx/rx masks > > > > > fall into the available antennas mask. > > > > > > > > Allright, I can do that. Would you prefer to reject the command in > > > > this case or just apply the available mask? > > > > > > I'd reject it, since userspace could have checked whether it was valid. > > > > Hmm, been thinking about it: the "iw phyX set antenna all" will not work > > in that case. Unless we get the available antennas before setting "all" > > in iw, which seems like a lot of overhead... > > > > Alternatively we can either apply the mask in mac80211 or just hand the > > antenna masks as they are to the driver, which is what we do now. > > I think I'd be more happy with treating ~0 as special (which it is > anyway, apply the mask to it) and allowing that to not match the mask. > That way, the most common errors still don't have to be handled in the > driver. Allright. Sent a patch for this. bruno -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
