On Mon December 6 2010 17:33:20 Johannes Berg wrote: > > > Finally, you should check for nl80211 that the given tx/rx masks fall > > > into the available antennas mask. > > > > Allright, I can do that. Would you prefer to reject the command in this > > case or just apply the available mask? > > I'd reject it, since userspace could have checked whether it was valid. Hmm, been thinking about it: the "iw phyX set antenna all" will not work in that case. Unless we get the available antennas before setting "all" in iw, which seems like a lot of overhead... Alternatively we can either apply the mask in mac80211 or just hand the antenna masks as they are to the driver, which is what we do now. I think either way it's not a big deal. bruno -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html