On Thu, Dec 02, 2010 at 05:46:05PM +0530, Julian Calaby wrote:
> On Thu, Dec 2, 2010 at 23:09, Vasanthakumar Thiagarajan
> <vasanth@xxxxxxxxxxx> wrote:
> > No, these are to separate things.
>
> Are you sure? you seem to be doing:
>
> if (!AR_SREV_9485(ah)) {
> // CODE
> }
>
> if (AR_SREV_9485(ah)) {
> // MORE CODE
> }
>
> which I'm certain can be simlified as:
>
> if (!AR_SREV_9485(ah)) {
> // CODE
> } else {
> // MORE CODE
> }
>
> unless you're telling me that the value of AR_SREV_9485(ah) can change
> in the course of the first statement.
I mean the register configuration. In one case, chain 1 and chain 2
are irrelevant for AR9485. The second is antenna diversity is
enabled only for AR9485. Putting them in if..else would be
misleading, though is can be in if..else.
Vasanth
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
