On Thu, Dec 02, 2010 at 04:52:33PM +0530, Julian Calaby wrote: > Small nit: > > On Thu, Dec 2, 2010 at 22:07, Vasanthakumar Thiagarajan > <vasanth@xxxxxxxxxxx> wrote: > > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> > > --- > > drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 24 ++++++++++++++++++++---- > > drivers/net/wireless/ath/ath9k/ar9003_phy.h | 10 ++++++++++ > > 2 files changed, 30 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c > > index 02b6150..9ce6846 100644 > > --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c > > +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c > > @@ -3512,11 +3514,25 @@ static void ar9003_hw_ant_ctrl_apply(struct ath_hw *ah, bool is2ghz) > > value = ar9003_hw_ant_ctrl_chain_get(ah, 0, is2ghz); > > REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_0, AR_SWITCH_TABLE_ALL, value); > > > > - value = ar9003_hw_ant_ctrl_chain_get(ah, 1, is2ghz); > > - REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_1, AR_SWITCH_TABLE_ALL, value); > > + if (!AR_SREV_9485(ah)) { > > + value = ar9003_hw_ant_ctrl_chain_get(ah, 1, is2ghz); > > + REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_1, AR_SWITCH_TABLE_ALL, > > + value); > > > > - value = ar9003_hw_ant_ctrl_chain_get(ah, 2, is2ghz); > > - REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_2, AR_SWITCH_TABLE_ALL, value); > > + value = ar9003_hw_ant_ctrl_chain_get(ah, 2, is2ghz); > > + REG_RMW_FIELD(ah, AR_PHY_SWITCH_CHAIN_2, AR_SWITCH_TABLE_ALL, > > + value); > > + } > > else? No, these are to separate things. Vasanth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html