On 12/01/2010 08:40 AM, Helmut Schaa wrote: > Hi, > > Am Mittwoch 01 Dezember 2010 schrieb Mohammed Shafi: >> On Wed, Dec 1, 2010 at 4:48 PM, Helmut Schaa >> <helmut.schaa@xxxxxxxxxxxxxx> wrote: >>> The last_tx_rate field was also updated for non-data frames that are >>> often sent with a lower rate (for example management frames at 1 Mbps). >>> This is confusing when the data rate is actually much higher. >>> >>> Hence, only update the last_tx_rate field with tx rate information >>> gathered from the last data frames. >> >> Hi Helmut, >> I have a doubt,ideally should not this be taken care by the driver ? > > Sorry, I don't get your point. How should that be handled by the driver? Could > you please elaborate? > > last_tx_rate is part of the sta_info struct and is documented as: > > 207 * @last_tx_rate: rate used for last transmit, to report to userspace as > 208 * "the" transmit rate > > So, the fields sole purpose is to report the "current" tx rate to user space. > A normal user (IMO) would like to see the current tx rate that is used for > data frames and not occasionally a 1Mbps because a management frame was the > last sent frame. In the openSUSE forums, we occasionally get a confused user that says "the wireless only runs at 1 Mb/s" because that is what iwconfig says. On inspection, the throughput is much higher. I vote for reporting the last data frame rate and ignore management frames. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
