On Wed, Dec 1, 2010 at 8:44 PM, Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx> wrote: > Am Mittwoch 01 Dezember 2010 schrieb Helmut Schaa: >> Am Mittwoch 01 Dezember 2010 schrieb Mohammed Shafi: >> > On Wed, Dec 1, 2010 at 4:48 PM, Helmut Schaa >> > <helmut.schaa@xxxxxxxxxxxxxx> wrote: >> > > The last_tx_rate field was also updated for non-data frames that are >> > > often sent with a lower rate (for example management frames at 1 Mbps). >> > > This is confusing when the data rate is actually much higher. >> > > >> > > Hence, only update the last_tx_rate field with tx rate information >> > > gathered from the last data frames. >> > >> > Hi Helmut, >> > I have a doubt,ideally should not this be taken care by the driver ? >> >> Sorry, I don't get your point. How should that be handled by the driver? Could >> you please elaborate? > > Ahh, did you mean that should be taken care of by the rate control algorithm? > I think so but not sure..(for ex: if ministrel is used) > I agree, if the rate control algortihm returns a rate via txrc.reported_rate > we should just use that without further validation. > > Nevertheless, if the rate control algortihm doesn't fill in txrc.reported_rate > we should only account data frames. I agree. > > Will send an updated patch. > > Helmut > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
