Hi, On Mon, Nov 22, 2010 at 1:09 PM, Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> wrote: > On Sun, Nov 21, 2010 at 5:36 PM, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote: >> [...] >> The compat headers should be at the end of the include list, so that >> the kernel headers get included first, and the compat one will only be >> when the kernel does not provide the header. This is the only sane way >> to override kernel provided stuff. That said, there is certainly a >> use-case I missed. > > Agreed, but you are missing the purpose of the trick used here. certainly :) > The > purpose of the include_next was so that we can name our own > <linux/pm_qos_params.h> which is part of compat and these directories > *will* get a priority over the kernel's so that way we can avoid > ifdef'ing all includes for the same file on the upstream code. I'm not sure to get what you mean by "we can avoid ifdef'ing all includes for the same file on the upstream code", can you details ? > Without > an include_next we'd simply skip including the kernel's own original > header file. > I admit that I removed that part merely because I went loose on the trigger that day. AFAIR, there was no technical point per-se, so I would not mind omitting this patch. - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
