Search Linux Wireless

Re: [PATCH 28/44] compat: avoid using `#include_next' directive in compat headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Nov 10, 2010 at 5:24 PM, Luis R. Rodriguez
<lrodriguez@xxxxxxxxxxx> wrote:
> On Tue, Nov 09, 2010 at 06:20:10PM -0800, Arnaud Lacombe wrote:
>> Signed-off-by: Arnaud Lacombe <lacombar@xxxxxxxxx>
>> ---
>>  include/linux/pm_qos_params.h |    7 +++----
>>  include/linux/tracepoint.h    |   14 +++++++-------
>>  include/net/net_namespace.h   |   14 +++++++-------
>>  include/trace/define_trace.h  |    5 -----
>>  4 files changed, 17 insertions(+), 23 deletions(-)
>>
>> diff --git a/include/linux/pm_qos_params.h b/include/linux/pm_qos_params.h
>> index e1f083c..8c69ab2 100644
>> --- a/include/linux/pm_qos_params.h
>> +++ b/include/linux/pm_qos_params.h
>> @@ -1,8 +1,7 @@
>>  #include <linux/version.h>
>>
>> -#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,25))
>> -#include_next <linux/pm_qos_params.h>
>> -#else
>> +#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,25))
>> +
>
> But will the kernels' own pm_qos_params.h be included for kernels >= 2.6.25?
>
The compat headers should be at the end of the include list, so that
the kernel headers get included first, and the compat one will only be
when the kernel does not provide the header. This is the only sane way
to override kernel provided stuff. That said, there is certainly a
use-case I missed.

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux