On Thu, 2010-11-18 at 11:27 -0500, John W. Linville wrote: > On Wed, Nov 17, 2010 at 06:12:56PM +0100, Michael BÃsch wrote: > > On Tue, 2010-11-16 at 16:23 -0500, John W. Linville wrote: > > > > - ssb_printk(KERN_WARNING PFX "Unsupported SPROM" > > > > - " revision %d detected. Will extract" > > > > - " v1\n", out->revision); > > > > - out->revision = 1; > > > > - sprom_extract_r123(out, in); > > > > + ssb_printk(KERN_ERR PFX "Unsupported SPROM revision %d" > > > > + " detected\n", out->revision); > > > > + return -EINVAL; > > > > } > > > > > > > > if (out->boardflags_lo == 0xFFFF) > > > > > > I think this is going to make my b43 PCI-E card not work...I'll try > > > it and get back to you... > > > > Hm, what version does it report? > [ 1036.293865] ssb: Unsupported SPROM revision 255 detected. Will extract v1 So what about specialcasing 255 instead of defaulting to 1 in general? if (rev == 255) rev = 1; 255 basically means "Vendor forgot to set this field". So it would only default to 1 for those broken sproms. -- Greetings Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
