I'm not familiar with the fullmac code so I am getting someone from fullmac team to answer...hang on just a little. In the meantime Mike, does the driver still work with all your patches? Thanks Brett > -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxx] > Sent: Wednesday, November 17, 2010 2:11 PM > To: Mike Rapoport > Cc: Greg KH; Brett Rudley; Henry Ptasinski; Dowan Kim; linux- > wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/4] staging: brcm80211: brcmfmac: remove PCI SDIO > controller binding > > On Thu, Nov 18, 2010 at 12:00:16AM +0200, Mike Rapoport wrote: > > On Wed, Nov 17, 2010 at 11:10 PM, Greg KH <greg@xxxxxxxxx> wrote: > > > On Wed, Nov 17, 2010 at 09:58:46AM +0200, Mike Rapoport wrote: > > >> Signed-off-by: Mike Rapoport <mike.rapoport@xxxxxxxxx> > > >> --- > > >> drivers/staging/brcm80211/brcmfmac/bcmsdh_linux.c | 229 ---------- > ----------- > > >> 1 files changed, 0 insertions(+), 229 deletions(-) > > > > > > Wait, is this really ok code to be removing from the driver? > > > > > > Brett and Henry, any objections to this? > > > > > > Mike, why do you think this is ok to remove? Is it because no one is > > > ever calling this even for both types of config for this driver? > > > > There's a lot of code in the brcmfmac part of the driver that tries to > > re-implement SDIO stack. In particular, the code removed by this patch > > registers a pci_driver for SDIO controller and then the brcmfmac > > driver accesses the WiFi device attached to that SDIO controller by > > means of custom re-implementation of SDHC. > > Ok, so even with this patch, it will still work properly in the SDIO > mode? > > Have you been able to test this? > > Brett, Henry, I would like to get your ack on this before applying it. > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
