On Fri, Nov 12, 2010 at 08:55:36PM +0100, Felix Fietkau wrote: > On 2010-11-12 8:51 PM, Wojciech Dubowik wrote: > >> Having both in the kernel is completely pointless. There are no > >> devices > >> that can support both, nor will there ever be. > > > > I agree. The only advantage would be that some of the typos and missing > > functions in either of the files would be detected during compile time. Compile-testing coverage is a fine reason to allow people to compile both modules. Ok, I accept that it's a bit of a pain to create separate modules, but can we at least do it like: ath5k-$(CONFIG_ATH5K_PCI) += pci.o ath5k-$(CONFIG_ATH5K_AHB) += ahb.o and add the appropriate selects and mutual exclusion to the Kconfig? Of course, that presupposes a Kconfig entry for CONFIG_ATHEROS_AR2316 where there is not one currently. -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
