> From: "Felix Fietkau" <nbd@xxxxxxxxxxx> > To: "Bob Copeland" <me@xxxxxxxxxxxxxxx> > Cc: "Wojciech Dubowik" <dubowoj@xxxxxxxxxxx>, linville@xxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx > Sent: Freitag, 12. November 2010 20:36:51 > Subject: Re: [PATCH 8/9] ath5k: AHB port. Add AHB bus support. > On 2010-11-12 8:26 PM, Bob Copeland wrote: > > On Thu, Nov 11, 2010 at 9:58 AM, Wojciech Dubowik > > <dubowoj@xxxxxxxxxxx> wrote: > >> > >> AHB specific functions are now in ahb.c file. There is no common > >> init functions which tries first pci and then ahb becasue on some > > > > 'because' > > > >> --- a/drivers/net/wireless/ath/ath5k/Makefile > >> +++ b/drivers/net/wireless/ath/ath5k/Makefile > >> @@ -15,5 +15,5 @@ ath5k-y += rfkill.o > >> ath5k-y += ani.o > >> ath5k-y += sysfs.o > >> ath5k-$(CONFIG_ATH5K_DEBUG) += debug.o > >> -ath5k-y += pci.o > >> +ath5k-y += $(if $(CONFIG_ATHEROS_AR231X),ahb,pci).o > >> obj-$(CONFIG_ATH5K) += ath5k.o > > > > This is not the right way.. what if someone wants both in one > > kernel? > Having both in the kernel is completely pointless. There are no > devices > that can support both, nor will there ever be. > > - Felix I agree. The only advantage would be that some of the typos and missing functions in either of the files would be detected during compile time. My AR5312 board crashes when I enable PCI. I guess it's fixable but it's out of the scope of the ath5k driver... br, Wojtek -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
