W dniu 15 paÅdziernika 2010 16:13 uÅytkownik GÃbor Stefanik <netrolller.3d@xxxxxxxxx> napisaÅ: > 2010/10/15 RafaÅ MiÅecki <zajec5@xxxxxxxxx>: >> W dniu 15 paÅdziernika 2010 00:39 uÅytkownik GÃbor Stefanik >> <netrolller.3d@xxxxxxxxx> napisaÅ: >>> 2010/10/14 RafaÅ MiÅecki <zajec5@xxxxxxxxx>: >>>> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx> >>>> --- >>>> Âdrivers/net/wireless/b43/radio_2056.c |  51 +++++++++++++++++++++++++++++++++ >>>> Âdrivers/net/wireless/b43/radio_2056.h |  40 ++++++++++++++++++++++++-- >>>> Â2 files changed, 88 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/net/wireless/b43/radio_2056.c b/drivers/net/wireless/b43/radio_2056.c >>>> index d856319..f710c01 100644 >>>> --- a/drivers/net/wireless/b43/radio_2056.c >>>> +++ b/drivers/net/wireless/b43/radio_2056.c >>>> @@ -24,9 +24,60 @@ >>>> Â#include "radio_2056.h" >>>> Â#include "phy_common.h" >>>> >>>> +#define RADIOREGS3(r00, r01, r02, r03, r04, r05, r06, r07, r08, r09, \ >>>> +         Âr10, r11, r12, r13, r14, r15, r16, r17, r18, r19, \ >>>> +         Âr20, r21, r22, r23, r24, r25, r26, r27, r28, r29, \ >>>> +         Âr30, r31, r32, r33, r34, r35, r36) \ >>>> +    .radio_syn_pll_vcocal1     Â= r00, Â\ >>>> +    .radio_syn_pll_vcocal2     Â= r01, Â\ >>>> +    .radio_syn_pll_refdiv      = r02, Â\ >>>> +    .radio_syn_pll_mmd2       = r03, Â\ >>>> +    .radio_syn_pll_mmd1       = r04, Â\ >>>> +    .radio_syn_pll_loopfilter1   Â= r05, Â\ >>>> +    .radio_syn_pll_loopfilter2   Â= r06, Â\ >>>> +    .radio_syn_pll_loopfilter3   Â= r07, Â\ >>>> +    .radio_syn_pll_loopfilter4   Â= r08, Â\ >>>> +    .radio_syn_pll_loopfilter5   Â= r09, Â\ >>>> +    .radio_syn_reserved_addr27   Â= r10, Â\ >>>> +    .radio_syn_reserved_addr28   Â= r11, Â\ >>>> +    .radio_syn_reserved_addr29   Â= r12, Â\ >>>> +    .radio_syn_logen_vcobuf1    Â= r13, Â\ >>>> +    .radio_syn_logen_mixer2     = r14, Â\ >>>> +    .radio_syn_logen_buf3      = r15, Â\ >>>> +    .radio_syn_logen_buf4      = r16, Â\ >>>> +    .radio_rx0_lnaa_tune      Â= r17, Â\ >>>> +    .radio_rx0_lnag_tune      Â= r18, Â\ >>>> +    .radio_tx0_intpaa_boost_tune  Â= r19, Â\ >>>> +    .radio_tx0_intpag_boost_tune  Â= r20, Â\ >>>> +    .radio_tx0_pada_boost_tune   Â= r21, Â\ >>>> +    .radio_tx0_padg_boost_tune   Â= r22, Â\ >>>> +    .radio_tx0_pgaa_boost_tune   Â= r23, Â\ >>>> +    .radio_tx0_pgag_boost_tune   Â= r24, Â\ >>>> +    .radio_tx0_mixa_boost_tune   Â= r25, Â\ >>>> +    .radio_tx0_mixg_boost_tune   Â= r26, Â\ >>>> +    .radio_rx1_lnaa_tune      Â= r27, Â\ >>>> +    .radio_rx1_lnag_tune      Â= r28, Â\ >>>> +    .radio_tx1_intpaa_boost_tune  Â= r29, Â\ >>>> +    .radio_tx1_intpag_boost_tune  Â= r30, Â\ >>>> +    .radio_tx1_pada_boost_tune   Â= r31, Â\ >>>> +    .radio_tx1_padg_boost_tune   Â= r32, Â\ >>>> +    .radio_tx1_pgaa_boost_tune   Â= r33, Â\ >>>> +    .radio_tx1_pgag_boost_tune   Â= r34, Â\ >>>> +    .radio_tx1_mixa_boost_tune   Â= r35, Â\ >>>> +    .radio_tx1_mixg_boost_tune   Â= r36 >>> >>> You might want to use parentheses around parameter names: e.g.: >>> .radio_tx1_mixa_boost_tune = (r35), \ >> >> We use this macro only for defining radio tables, only in this file. >> Plus we don't use any math or sth as you can see in next patch (3/3). >> That way it will not hit random developer using this macro in other >> place of code. > > That's OK, but I believe that there is a coding style requirement to > always parenthesize macro parameters. If there isn't, then it's OK. There is "Chapter 12: Macros, Enums and RTL" in: http://www.kernel.org/doc/Documentation/CodingStyle Some quotes: 1) "Macros with multiple statements should be enclosed in a do - while block:" 2) "macros defining constants using expressions must enclose the expression in parentheses" Second one may sound like sth close, but it's just about expressions like: #define CONSTEXP (CONSTANT | 3) So there doesn't seem to be any "rule" in CodingStyle wanting us to add parentheses when you suggested. -- RafaÅ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
