Search Linux Wireless

Re: [PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 15 paÅdziernika 2010 00:39 uÅytkownik GÃbor Stefanik
<netrolller.3d@xxxxxxxxx> napisaÅ:
> 2010/10/14 RafaÅ MiÅecki <zajec5@xxxxxxxxx>:
>> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
>> ---
>> Âdrivers/net/wireless/b43/radio_2056.c | Â 51 +++++++++++++++++++++++++++++++++
>> Âdrivers/net/wireless/b43/radio_2056.h | Â 40 ++++++++++++++++++++++++--
>> Â2 files changed, 88 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/radio_2056.c b/drivers/net/wireless/b43/radio_2056.c
>> index d856319..f710c01 100644
>> --- a/drivers/net/wireless/b43/radio_2056.c
>> +++ b/drivers/net/wireless/b43/radio_2056.c
>> @@ -24,9 +24,60 @@
>> Â#include "radio_2056.h"
>> Â#include "phy_common.h"
>>
>> +#define RADIOREGS3(r00, r01, r02, r03, r04, r05, r06, r07, r08, r09, \
>> + Â Â Â Â Â Â Â Â Âr10, r11, r12, r13, r14, r15, r16, r17, r18, r19, \
>> + Â Â Â Â Â Â Â Â Âr20, r21, r22, r23, r24, r25, r26, r27, r28, r29, \
>> + Â Â Â Â Â Â Â Â Âr30, r31, r32, r33, r34, r35, r36) \
>> + Â Â Â .radio_syn_pll_vcocal1 Â Â Â Â Â= r00, Â\
>> + Â Â Â .radio_syn_pll_vcocal2 Â Â Â Â Â= r01, Â\
>> +    .radio_syn_pll_refdiv      = r02, Â\
>> + Â Â Â .radio_syn_pll_mmd2 Â Â Â Â Â Â = r03, Â\
>> + Â Â Â .radio_syn_pll_mmd1 Â Â Â Â Â Â = r04, Â\
>> + Â Â Â .radio_syn_pll_loopfilter1 Â Â Â= r05, Â\
>> + Â Â Â .radio_syn_pll_loopfilter2 Â Â Â= r06, Â\
>> + Â Â Â .radio_syn_pll_loopfilter3 Â Â Â= r07, Â\
>> + Â Â Â .radio_syn_pll_loopfilter4 Â Â Â= r08, Â\
>> + Â Â Â .radio_syn_pll_loopfilter5 Â Â Â= r09, Â\
>> + Â Â Â .radio_syn_reserved_addr27 Â Â Â= r10, Â\
>> + Â Â Â .radio_syn_reserved_addr28 Â Â Â= r11, Â\
>> + Â Â Â .radio_syn_reserved_addr29 Â Â Â= r12, Â\
>> + Â Â Â .radio_syn_logen_vcobuf1 Â Â Â Â= r13, Â\
>> + Â Â Â .radio_syn_logen_mixer2 Â Â Â Â = r14, Â\
>> + Â Â Â .radio_syn_logen_buf3 Â Â Â Â Â = r15, Â\
>> + Â Â Â .radio_syn_logen_buf4 Â Â Â Â Â = r16, Â\
>> +    .radio_rx0_lnaa_tune      Â= r17, Â\
>> +    .radio_rx0_lnag_tune      Â= r18, Â\
>> +    .radio_tx0_intpaa_boost_tune  Â= r19, Â\
>> +    .radio_tx0_intpag_boost_tune  Â= r20, Â\
>> +    .radio_tx0_pada_boost_tune   Â= r21, Â\
>> +    .radio_tx0_padg_boost_tune   Â= r22, Â\
>> +    .radio_tx0_pgaa_boost_tune   Â= r23, Â\
>> +    .radio_tx0_pgag_boost_tune   Â= r24, Â\
>> +    .radio_tx0_mixa_boost_tune   Â= r25, Â\
>> +    .radio_tx0_mixg_boost_tune   Â= r26, Â\
>> +    .radio_rx1_lnaa_tune      Â= r27, Â\
>> +    .radio_rx1_lnag_tune      Â= r28, Â\
>> +    .radio_tx1_intpaa_boost_tune  Â= r29, Â\
>> +    .radio_tx1_intpag_boost_tune  Â= r30, Â\
>> +    .radio_tx1_pada_boost_tune   Â= r31, Â\
>> +    .radio_tx1_padg_boost_tune   Â= r32, Â\
>> +    .radio_tx1_pgaa_boost_tune   Â= r33, Â\
>> +    .radio_tx1_pgag_boost_tune   Â= r34, Â\
>> +    .radio_tx1_mixa_boost_tune   Â= r35, Â\
>> +    .radio_tx1_mixg_boost_tune   Â= r36
>
> You might want to use parentheses around parameter names: e.g.:
> .radio_tx1_mixa_boost_tune = (r35), \

We use this macro only for defining radio tables, only in this file.
Plus we don't use any math or sth as you can see in next patch (3/3).
That way it will not hit random developer using this macro in other
place of code.

-- 
RafaÅ
ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux