Search Linux Wireless

RE: [WL1271 DC support on OMAP3EVM 2/5] ARM: Supported for Standard SDIO driver on OMAP3EVM for WL1271 DC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Sanjay Kumar Champati [mailto:csanjay@xxxxxxxxxxxxxxxxxxxx] 
> Sent: Wednesday, October 13, 2010 5:50 PM
> To: Premi, Sanjeev; linux-omap@xxxxxxxxxxxxxxx
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Subject: RE: [WL1271 DC support on OMAP3EVM 2/5] ARM: 
> Supported for Standard SDIO driver on OMAP3EVM for WL1271 DC
> 
[snip]...[snip]

> > > diff --git a/drivers/mmc/core/sdio_ops.c 
> b/drivers/mmc/core/sdio_ops.c
> > > index 4eb7825..4213ee0 100644
> > > --- a/drivers/mmc/core/sdio_ops.c
> > > +++ b/drivers/mmc/core/sdio_ops.c
> > > @@ -114,6 +114,9 @@ int mmc_io_rw_direct(struct mmc_card
> > > *card, int write, unsigned fn,
> > >
> > >  	return 0;
> > >  }
> > > +#ifdef CONFIG_WL1271_WLAN
> > > +EXPORT_SYMBOL(mmc_io_rw_direct);
> > > +#endif
> > 
> > [sp] Why is the export required?
> For the standard SDIO support WL1271 driver is using 
> "mmc_io_rw_direct".
> > 
> > >
> > >  int mmc_io_rw_extended(struct mmc_card *card, int write, 
> unsigned fn,
> > >  	unsigned addr, int incr_addr, u8 *buf, unsigned blocks,
> > > unsigned blksz)
> > > @@ -181,4 +184,6 @@ int mmc_io_rw_extended(struct mmc_card
> > > *card, int write, unsigned fn,
> > >
> > >  	return 0;
> > >  }
> > > -
> > > +#ifdef CONFIG_WL1271_WLAN
> > > +EXPORT_SYMBOL(mmc_io_rw_extended);
> > > +#endif
> > 
> > [sp] Why is the export required?
> For the standard SDIO support WL1271 driver is using 
> "mmc_io_rw_extended".
> > 

[sp] part of my question is: Why do you need to modify the
     generic sdio implementation to export these functions?

     You cannot make "custom" modifications here. See similar
     comment in other patch as well.

[snip]...[snip]
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux