On Wed, Oct 13, 2010 at 03:31:47PM +0530, Felix Fietkau wrote: > On 2010-10-13 7:20 AM, Rajkumar Manoharan wrote: > > On Tue, Oct 12, 2010 at 07:38:03PM +0530, Felix Fietkau wrote: > >> + spin_lock(&common->cc_lock); > >> ath9k_hw_proc_mib_event(ah); > >> + spin_unlock(&common->cc_lock); > >> ath9k_hw_set_interrupts(ah, ah->imask); > >> } > >> > > shouldn't we lock ath9k_ani_reset which also restarts ani? > No, cc_lock is not an ANI lock, it's only for the cycle counters, which > are not touched by ath9k_ani_reset at all. yes. cc_lock is meant for cycle counters. the confusion is that whether ani_reset uses cc_conter. It's obviously not. so there is no need for for locking ani_reset with the current code. However I am wondering where are we resetting cc counters except ath_hw_get_listen_time() which is obviously called after ath_hw_cycle_counters_update(). There are plenty of cases where ani_reset is called and shouldn't we reset these counters somewhere ???. > > - Felix > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
