On Wed, 2010-10-06 at 21:38 +0200, Levi, Shahar wrote:
> > > /* peek into the rates configured in the STA entry */
> > > spin_lock_irqsave(&wl->wl_lock, flags);
> > > - if (sta && sta->supp_rates[conf->channel->band] != wl->sta_rate_set) {
> > > + if (sta &&
> > > + (sta->supp_rates[conf->channel->band] !=
> > > + (wl->sta_rate_set & HW_BG_RATES_MASK))) {
> > > wl->sta_rate_set = sta->supp_rates[conf->channel->band];
> > > set_bit(WL1271_FLAG_STA_RATES_CHANGED, &wl->flags);
> > > }
> >
> > ???
> >
> > How can non-BG rates ever show up there? Is this really an 11a change?
> >
> > johannes
>
>
> Thanks for the review.
> Non BG rates set in the next if:
> + if (sta &&
> + sta->ht_cap.ht_supported &&
> + ((wl->sta_rate_set >> HW_HT_RATES_OFFSET) !=
> + sta->ht_cap.mcs.rx_mask[0])) {
> + wl->sta_rate_set |=
> + (sta->ht_cap.mcs.rx_mask[0] << HW_HT_RATES_OFFSET);
> + set_bit(WL1271_FLAG_STA_RATES_CHANGED, &wl->flags);
> sta_rate_set bits are: bits0-15 BG, bits 16-23 MCS.
> Did you meant 11n change?
Never mind, I misread the patch.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
