> -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Wednesday, October 06, 2010 8:21 PM > To: Levi, Shahar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Luciano Coelho > Subject: Re: [PATCH v2 03/03] wl1271: 11n Support, functionality and > configuration ability > > On Wed, 2010-10-06 at 20:08 +0200, Shahar Levi wrote: > > > /* peek into the rates configured in the STA entry */ > > spin_lock_irqsave(&wl->wl_lock, flags); > > - if (sta && sta->supp_rates[conf->channel->band] != wl->sta_rate_set) { > > + if (sta && > > + (sta->supp_rates[conf->channel->band] != > > + (wl->sta_rate_set & HW_BG_RATES_MASK))) { > > wl->sta_rate_set = sta->supp_rates[conf->channel->band]; > > set_bit(WL1271_FLAG_STA_RATES_CHANGED, &wl->flags); > > } > > ??? > > How can non-BG rates ever show up there? Is this really an 11a change? > > johannes Thanks for the review. Non BG rates set in the next if: + if (sta && + sta->ht_cap.ht_supported && + ((wl->sta_rate_set >> HW_HT_RATES_OFFSET) != + sta->ht_cap.mcs.rx_mask[0])) { + wl->sta_rate_set |= + (sta->ht_cap.mcs.rx_mask[0] << HW_HT_RATES_OFFSET); + set_bit(WL1271_FLAG_STA_RATES_CHANGED, &wl->flags); sta_rate_set bits are: bits0-15 BG, bits 16-23 MCS. Did you meant 11n change? Regards, Shahar ÿô.nlj·Ÿ®‰†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf
