On Wed, Sep 22, 2010 at 6:49 AM, Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> wrote: > On Thu, Sep 16, 2010 at 07:49:39PM +0530, Luis R. Rodriguez wrote: >> On Wed, Sep 15, 2010 at 9:49 PM, Vasanthakumar Thiagarajan >> <vasanth@xxxxxxxxxxx> wrote: >> > On Wed, Sep 15, 2010 at 09:51:43PM +0530, Luis R. Rodriguez wrote: >> >> On Wed, Sep 15, 2010 at 7:22 AM, Vasanthakumar Thiagarajan >> >> <vasanth@xxxxxxxxxxx> wrote: >> >> > Author: Felix Fietkau <nbd@xxxxxxxxxxx> >> >> > Date: Â Sat Jul 31 00:11:59 2010 +0200 >> >> > >> >> > Â Âath9k: prevent calibration during off-channel activity >> >> > >> >> > The above patch checks for off-channel before starting ANI, >> >> > but when the operating channel is set right after association, >> >> > IEEE80211_CONF_OFFCHANNEL would be set as still local->tmp_channel >> >> > is non-NULL. This would result in not starting calibration after >> >> > the association. >> > >> > Yes, the bug is in mac80211, but fixing this one in mac80211 looks >> > not straight forward and probably Felix would know this one better, >> > for now let me do this in driver and remove it once it is cleanly >> > fixed in mac80211. >> >> No, please address in mac80211, if we clean this up as a work around >> we likely are overlooking other possible issues which can be affected >> as well. > > It is not easy (from my understanding at least) to fix this in > mac80211 as the assumption of off-channel activity (IEEE80211_CONF_OFFCHANNEL) > itself seems to be wrong sometimes (in case of station mode, setting this flag > before the association does not look right). As I dont know any > clean fix in mac80211, this patch can be an interim fix for the > regression. It was tricky indeed, mac80211 does use the offchannel operation to associate as an atomic operation, the fix was to lif the offchannel flag when we have already decided we are going to switch to it as our home channel. Please try the patch "mac80211: fix offchannel assumption upon association". Works for me. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
