On Sat, 2010-09-25 at 22:28 -0700, greearb@xxxxxxxxx wrote: > From: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > The recent patch that re-used phy indexes on module reload > could cause races. Instead, increment phy-index monitomically > for each new phy, but choose the first phy%d name that is > available. > > Also, allow users to rename a phy to any un-used name, including > phy%d. You lost the wiphy_counter-- because you'd first removed it and now reverted that patch ... it'd be easier to review if you actually did a new patch on top of the revert. The wiphy_counter-- seems necessary to avoid potential wrapping and then re-using phy index 0 (yeah, you'd have to have an immense amount of phy registration going on ... but still) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html