On Mon, 2010-09-27 at 10:48 +0200, ext Johannes Berg wrote: > On Mon, 2010-09-27 at 11:37 +0300, Luciano Coelho wrote: > > From: Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx> > > > > The mac80211 inserts channels into a scan request in the same order the driver > > registers them. Use this fact to optimize scan by ordering the channels so > > that adjacent channels don't get scanned consecutively. > > Cute, but not really ... > > First of all, iw will also report channels in this order, and that's > just weird. > > Secondly, if you pass any channels to scan manually (say with iw), this > assertion is no longer true -- cfg80211 will actually _sort_ the > channels in that case to make sure there are no duplicates. > > So you really shouldn't be doing this. Indeed, thanks for pointing out. This was a shortcut that seemed so easy to follow that we couldn't resist. I think we can release this patch as is, because it already helps in some cases. And we'll come with a proper and generic solution in mac80211/cfg80211 soon. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
