On Mon, 2010-09-27 at 10:51 +0200, ext Johannes Berg wrote: > On Mon, 2010-09-27 at 11:37 +0300, Luciano Coelho wrote: > > > - /* queue */ > > + /* queue (we use same identifiers for tid's and ac's */ > > ac = wl1271_tx_get_queue(skb_get_queue_mapping(skb)); > > - desc->tid = wl1271_tx_ac_to_tid(ac); > > + desc->tid = ac; > > That cannot be right unless the "tid" field in "desc" should really be > named "ac", since there are twice as many TIDs as ACs. Nor can > "ac_to_tid" ever be a valid function, for the same reason, it can't be a > surjective function. You are probably confused by the name "tid", by which name TI refers to this field. Practically, currently, it is essentially the same thing as AC. The mapping between the tid's and AC's is specified in the wl1271 driver, and you'll find AC's and tid's are one-to-one. The naming of this field is like this due to planned future implementation. -Juuso > If you need the TID (with some fallback for non-QoS frames) you should > probably add that to the tx info somehow. > > johannes > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
