Search Linux Wireless

Re: [PATCH 17/25] wl1271: Fix tid-configuration of TX frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-09-27 at 11:37 +0300, Luciano Coelho wrote:

> -	/* queue */
> +	/* queue (we use same identifiers for tid's and ac's */
>  	ac = wl1271_tx_get_queue(skb_get_queue_mapping(skb));
> -	desc->tid = wl1271_tx_ac_to_tid(ac);
> +	desc->tid = ac;

That cannot be right unless the "tid" field in "desc" should really be
named "ac", since there are twice as many TIDs as ACs. Nor can
"ac_to_tid" ever be a valid function, for the same reason, it can't be a
surjective function.

If you need the TID (with some fallback for non-QoS frames) you should
probably add that to the tx info somehow.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux