Search Linux Wireless

Re: [PATCH v1 7/8] sdio: enable Runtime PM for SDIO functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

On Tue, Sep 14, 2010 at 9:27 PM, Chris Ball <cjb@xxxxxxxxxx> wrote:
> On Tue, Sep 07, 2010 at 02:29:08PM +0300, Ohad Ben-Cohen wrote:
> > @@ -152,6 +173,11 @@ static int sdio_bus_remove(struct device *dev)
> >               sdio_release_host(func);
> >       }
> >
> > +     pm_runtime_put_noidle(dev);
> > +
> > +     /* Undo the runtime PM settings in sdio_bus_probe() */
> > +     pm_runtime_put_noidle(dev);
> > +
> >       return 0;
> >  }
> >
>
> Nit:  This makes sense in context, but stands out as a possible paste
> accident on first sight.  :)  I think it's worth adding a comment to
> the first call

Will do, thanks for the review!

Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux