Search Linux Wireless

Re: [virtual-sta 1/3] mac80211: Add more general interface iterator.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/14/2010 05:59 AM, Johannes Berg wrote:
On Fri, 2010-09-10 at 15:04 -0700, greearb@xxxxxxxxxxxxxxx wrote:

This allows callers to specify whether they want all
or just active interfaces,

I thought about this, and I don't want to allow drivers to get at
inactive interfaces. And with that, I don't think there's a need to
restructure the code here. Also, since what you wanted wasn't the count
but the STA interface count, you need your own iterator function anyway,
no?

I'll see if I can get ath9k to use the normal iterator.  I didn't need my
own iterator, because I could just pass in NULL for iterator and pass
active_only as false.

I think you should consider returning the count for the number of times the
iterator was called because it's simple code, and it would save the same logic
in each driver's iterator methods (or at least, ath9k).

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux