On Wed, 2010-08-25 at 20:26 -0700, Colin McCabe wrote: > On Tue, Aug 24, 2010 at 5:15 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote: > > On Tue, 2010-08-24 at 14:07 +0200, Dan Carpenter wrote: > >> The indenting is not correct here. I don't have this hardware and I'm > >> just guessing as to what was intended. I think that if there is an > >> error we should return an error code, but if there isn't an error we > >> should return success directly without releasing the firmware. > > [...] > > > > The driver doesn't use or refer to the firmware image once it's copied > > into device RAM, so this just leaks the firmware. > > > > The driver *should* keep a reference so it can restore the firmware > > after suspend/resume without filesystem access (which is likely to > > deadlock). > > Well, if all you want to do is put the device into "deep sleep" mode, > you will not need a firmware reload after waking it up. [...] I was thinking of system suspend/resume, which could remove all power from the device. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Attachment:
signature.asc
Description: This is a digitally signed message part
