On Tue, 2010-08-24 at 14:07 +0200, Dan Carpenter wrote: > The indenting is not correct here. I don't have this hardware and I'm > just guessing as to what was intended. I think that if there is an > error we should return an error code, but if there isn't an error we > should return success directly without releasing the firmware. [...] The driver doesn't use or refer to the firmware image once it's copied into device RAM, so this just leaks the firmware. The driver *should* keep a reference so it can restore the firmware after suspend/resume without filesystem access (which is likely to deadlock). Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Attachment:
signature.asc
Description: This is a digitally signed message part
