On 8/24/10 3:16 AM, Johannes Berg wrote:
On Fri, 2010-08-20 at 15:54 -0700, Philip Prindeville wrote:
What I'm trying to say is that even though the driver handles the
condition of nla_type == 0 when it generates the message, the
condition isn't handled correct when the message finally gets passed
up into user-space, because the above sequence in the netlink library
gets hit both for "iw" and "hostapd".
So it's not enough to handle it correctly in the driver: it needs to
be handled in libnl as well.
There are 3 potential solutions:
(1) go with a 1-based enum for the band, instead of 0-based;
(2) remove the test for nla_type == 0 in nla_parse() in libnl;
(3) use a way to convey the band that doesn't involve overloading
nla_type;
What's the correct fix?
You managed to totally throw me off course ... The problem is completely
unrelated to this, see the patch I just sent :-)
johannes
Confirmed your fix. http://pastebin.ca/1924624
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
