On Thu, 2010-08-19 at 14:26 -0700, Philip Prindeville wrote:
> > + /*
> > + * The nested attribute uses enum nl80211_band as the index. This maps
> > + * directly to the enum ieee80211_band values used in cfg80211.
> > + */
> > + nla_for_each_nested(tx_rates, info->attrs[NL80211_ATTR_TX_RATES], rem)
> > + {
> > + enum ieee80211_band band = nla_type(tx_rates);
>
> Can this even work? The first entry in nl80211_band is NL80211_BAND_2GHZ, i.e. zero.
>
> Yet looking at libnl-1.1/lib/attr.c there's:
>
> int nla_parse(struct nlattr *tb[], int maxtype, struct nlattr *head, int len,
> struct nla_policy *policy)
> {
> ...
> nla_for_each_attr(nla, head, len, rem) {
> int type = nla_type(nla);
>
> if (type == 0) {
Well, notice how you're quoting code that does the same thing
(for_each_attr), but the latter code does the extra non-zero check,
which we don't.
We don't use nla_parse for this, we have to use
nla_parse_nested/for_each_attr. Yeah, it's a little quirky, but still
works fine.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
