On Thu, 2010-07-29 at 22:39 +0200, Johannes Berg wrote: > > + int (*napi_poll)(struct napi_struct *napi, int budget); > > I'd prefer passing the hw here and having mac80211 wrap it in a simple > function that does the container_of magic? Anything preventing that? > Then the napi struct can be hidden from drivers. Ok actually that requires wrapping napi_complete() too, that doesn't seem worth it. Can you wrap the container_of() in an inline though and maybe do "struct napi_struct _napi;" and document it shouldn't really be touched or something? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html