On Thu, 2010-07-29 at 16:14 -0400, John W. Linville wrote:
> + struct napi_struct napi;
> + int napi_weight;
Why is the napi struct visible to drivers? Ok .. I see later.
> @@ -1679,6 +1684,8 @@ enum ieee80211_ampdu_mlme_action {
> * switch operation for CSAs received from the AP may implement this
> * callback. They must then call ieee80211_chswitch_done() to indicate
> * completion of the channel switch.
> + *
> + * @napi_poll: Poll Rx queue for incoming data frames.
should this document that napi_weight must be set?
> + int (*napi_poll)(struct napi_struct *napi, int budget);
I'd prefer passing the hw here and having mac80211 wrap it in a simple
function that does the container_of magic? Anything preventing that?
Then the napi struct can be hidden from drivers.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
